[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
----------------------------------------------+----------------------------
 Reporter:  pbiron                            |       Owner:  pbiron
     Type:  enhancement                       |      Status:  reopened
 Priority:  normal                            |   Milestone:  Future
                                              |  Release
Component:  Upgrade/Install                   |     Version:
 Severity:  normal                            |  Resolution:
 Keywords:  early has-patch has-testing-info  |     Focuses:
----------------------------------------------+----------------------------

Comment (by Boniu91):

 == Test report

 === Environment
 * WordPress 5.9-alpha-51272-src
 * WordPress-develop environment used

 === Tested
 1. `wp-content/upgrade/temp-backup` and `wp-content/upgrade/temp-
 backup/plugins` not writeable, the error is displayed in the Site Health
 2. The error and notice is displayed correctly when `disk_free_space`
 returns mentioned values.
 3. Worked as described
 4. Worked as described

 **Question related to 2nd point: **
 Is this function 100% reliable in all environments?

 **Question/suggestion related to 3rd point: **
 If we change permissions of `/upgrade/temp-backup/plugins/plugin_name/` it
 won't be possible to update the plugin `plugin_name` anymore. It will end
 up with error:
 `Could not move old version to the temp-backup directory.`
 There's no message inside the Site Health section about that. I think we
 could add kind of check, that would display a notice when `/upgrade/temp-
 backup/plugins/` or `/upgrade/temp-backup/themes/` are not empty and error
 when their content is **not** writeable.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:102>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform