[wp-trac] [WordPress Trac] #53940: Reconsider return types for `_get_cron_array()`.

WordPress Trac noreply at wordpress.org
Wed Aug 18 00:31:16 UTC 2021

#53940: Reconsider return types for `_get_cron_array()`.
 Reporter:  peterwilsoncc                 |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  Awaiting Review
Component:  Cron API                      |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:

Comment (by peterwilsoncc):

 Replying to [comment:2 jrf]:
 > Note: the BC break ''may'' be acceptable in this case as the function is
 marked as internal only.

 That's what I was thinking but hoping for thoughts from other committers
 such as yourself.

 There are a [https://wpdirectory.net/search/01FDB9W74DP9KWCZ2G0A86D38X few
 plugins in the repository using it directly], but a check of those with
 over 100,000 installs shows that many assume it's always an array and
 those that don't would be unaffected by such a change.

 > FYI: we discussed this function and the return type in last weeks
 livestream about PHP 8.1.

 Yeah, I saw that while cleaning the house on the weekend. It's what
 prompted me to start thinking whether it should always return an array.

Ticket URL: <https://core.trac.wordpress.org/ticket/53940#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list