[wp-trac] [WordPress Trac] #53635: PHP 8.1: various compatibility fixes

[WordPress Trac]

#53635: PHP 8.1: various compatibility fixes
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.9
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php81 has-patch has-unit-tests       |     Focuses:  coding-
  commit                                         |  standards
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 In [changeset:"51630" 51630]:
 {{{
 #!CommitTicketReference repository="" revision="51630"
 Code Modernization: Check the return type of `parse_url()` in
 `ms_cookie_constants()`.

 As per the PHP manual:
 > If the `component` parameter is omitted, an associative array is
 returned.
 > If the `component` parameter is specified, `parse_url()` returns a
 string (or an int, in the case of `PHP_URL_PORT`) instead of an array. If
 the requested component doesn't exist within the given URL, `null` will be
 returned.

 Reference: [https://www.php.net/manual/en/function.parse-
 url.php#refsect1-function.parse-url-returnvalues PHP Manual: parse_url():
 Return Values]

 It is entirely possible for the `siteurl` option to not have a "path"
 component.

 In PHP 8.1, this would lead to a `trim(): Passing null to parameter #1
 ($string) of type string is deprecated` notice.

 Changing the logic around and adding validation for the return type value
 of `parse_url()` prevents that.

 As this function is declaring global constants, adding tests for this
 change is not really an option without potentially affecting other tests.

 Follow-up to [51606], [51622], [51626], [51629].

 Props jrf, hellofromTonya, SergeyBiryukov.
 See #53635.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53635#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform