[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-----------------------------+-----------------------------
 Reporter:  pbiron           |       Owner:  pbiron
     Type:  enhancement      |      Status:  reopened
 Priority:  normal           |   Milestone:  Future Release
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  early has-patch  |     Focuses:
-----------------------------+-----------------------------

Comment (by pbiron):

 Following on the core-auto-updates slack discussion of this today, see
 [https://www.php.net/manual/en/function.rename.php#117590 this comment] on
 the PHP manual page for `rename()` for some of the pitfalls when the
 `$source` and `$destination` directions are on different filesystems.

 I don't think that's much of a problem for the PR, but it does mention
 there can be cases where `rename()` returns `true` even though there were
 "problems" with the operation.  We __may__ want to add some logic to
 `WP_Filesystem_Direct::move()` to trap those warnings and deal with them
 appropriately.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:95>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform