[wp-trac] [WordPress Trac] #40940: Twenty Twelve uses invalid linear-gradient() syntax

[WordPress Trac]

#40940: Twenty Twelve uses invalid linear-gradient() syntax
---------------------------+------------------------------
 Reporter:  vrubleg        |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  4.7.5
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:   => has-patch


Comment:

 Thanks for the report, and sorry for the delayed response.

 Since opening this ticket, the gradient syntax was corrected in
 changeset:45124.

 Changeset r22899 applied the gradient to `button` element in its
 hover/focus/active states, though not to the `button` element itself. For
 consideration, [attachment:"40940.patch"] adds that. This would alter the
 styling for at least the search block's submit button and custom buttons
 (in Custom HTML or Classic blocks, or within a child theme template).

 I did not include changes for the following, but of course they still
 might be worth editing.
 1. Removing vendor prefixes: Yes, these are probably all unnecessary at
 this point. For comparison, Twenty Thirteen only has the `-webkit` prefix,
 and Twenty Seventeen includes others again. Twenty Twenty and Twenty
 Twenty-One do not include prefixes for gradients.
 2. Removing the `.comments-area article header h4` style: I cannot find an
 `h4` heading in the comments section, even in the
 [https://themes.trac.wordpress.org/browser/twentytwelve/1.0/functions.php#L275
 original functions.php file].
 3. Editing `.bypostauthor cite span`: I think this part would be better to
 leave as it is. The second set overrides ''almost'' all properties from
 the first, but it maintains the font-size and line-height. (Adding those
 three lines could negate the benefit of removing the three that reset.)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40940#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform