[wp-trac] [WordPress Trac] #53651: unit test for wp_removable_query_args

[WordPress Trac]

#53651: unit test for wp_removable_query_args
------------------------------+------------------------------
 Reporter:  pbearne           |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  needs-unit-tests  |     Focuses:
------------------------------+------------------------------
Changes (by johnbillion):

 * keywords:  has-patch has-unit-tests => needs-unit-tests
 * milestone:  5.9 => Awaiting Review


Comment:

 Thanks for the PR @pbearne but I question how useful these tests are.
 What's being tested exactly?

 * The `test_wp_removable_query_args()` test only confirms that the fixed
 set of values in the function matches the same fixed set of values in the
 test, and doesn't add assurance of anything.
 * The `test_wp_removable_query_args_filter()` test is only testing that a
 filter works, which is unrelated to the function being tested.

 I'm all for adding more tests, but as-is these don't provide any value.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53651#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform