[wp-trac] [WordPress Trac] #53891: GH Actions: enable running the tests on PHP 8.1

[WordPress Trac]

#53891: GH Actions: enable running the tests on PHP 8.1
-----------------------------------+-----------------------
 Reporter:  jrf                    |       Owner:  jrf
     Type:  task (blessed)         |      Status:  reopened
 Priority:  normal                 |   Milestone:  5.9
Component:  Build/Test Tools       |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch php81 early  |     Focuses:
-----------------------------------+-----------------------
Changes (by desrosj):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:9 swissspidy]:
 > Regarding r51588, couldn't the test workflow be simplified by just using
 `continue-on-error: ${{ matrix.php == '8.1' }}` instead of duplicating all
 steps?

 I also came here to suggest this.

 I did some testing, and I was able to get this to work. It looks like
 [attachment:"53891-ghactions-change.patch"] added `continue-on-error` at
 the job level. I did not retry this approach, though
 [https://docs.github.com/en/actions/reference/workflow-syntax-for-github-
 actions#jobsjob_idcontinue-on-error it is documented as supported].
 Instead I included `continue-on-error` inline for each step that should be
 allowed to fail for PHP 8.1. This makes what can fail more specific, and
 could help us debug other parts of the workflow on PHP 8.1.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53891#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform