[wp-trac] [WordPress Trac] #53897: PHP 8.1: strftime() is deprecated

[WordPress Trac]

#53897: PHP 8.1: strftime() is deprecated
------------------------------------------+---------------------
 Reporter:  jrf                           |       Owner:  (none)
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  5.9
Component:  Build/Test Tools              |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  has-patch early php81 commit  |     Focuses:
------------------------------------------+---------------------
Changes (by jrf):

 * keywords:  has-patch early php81 => has-patch early php81 commit


Comment:

 Reviewed @SergeyBiryukov addition and all looks good.

 Good call on removing the duplicate function calls.

 I'm curious about why these tests were using `gmstrftime()` (GMT based),
 not `strftime()` like the other tests, but a `git blame` just got me to
 the initial test commits, so I guess we're out of luck to try and find
 out.

 Tests on PHP 5.6 - 8.0 all still pass with these changes, so as far as I'm
 concerned, this is good to go.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53897#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform