[wp-trac] [WordPress Trac] #53858: PHP 8.1: syntax error due to new 'readonly' property
WordPress Trac
noreply at wordpress.org
Sun Aug 8 16:55:44 UTC 2021
#53858: PHP 8.1: syntax error due to new 'readonly' property
-------------------------------------------------+-------------------------
Reporter: haosun | Owner: jrf
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.9
Component: General | Version:
Severity: normal | Resolution:
Keywords: php81 needs-dev-note has-patch | Focuses:
early has-unit-tests commit |
-------------------------------------------------+-------------------------
Changes (by jrf):
* keywords: php81 needs-dev-note has-patch early has-unit-tests => php81
needs-dev-note has-patch early has-unit-tests commit
Comment:
@ayeshrajans @SergeyBiryukov I've opened a PR on GitHub which incorporates
@ayeshrajans's patch and improves the tests for the complete set of
`__checked_selected_helper()` related methods.
I've also ran the tests on PHP 8.1 and they pass, so as far as I'm
concerned, this should now be good to go, though a critical look is, of
course, welcome.
For anyone interested: you may find it educational to look at what I've
done with the tests.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53858#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list