[wp-trac] [WordPress Trac] #50683: Parse content for shortcodes instead of using regex

[WordPress Trac]

#50683: Parse content for shortcodes instead of using regex
-------------------------------------------------+-------------------------
 Reporter:  cfinke                               |       Owner:
                                                 |  johnbillion
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.9
Component:  Shortcodes                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests early       |     Focuses:
  needs-testing early-like-actually-early        |
  needs-testing-info                             |
-------------------------------------------------+-------------------------

Comment (by johnbillion):

 Performance variance is below.

 This has quite a big performance impact on PHP 5.6 and 7.0 which is
 concerning. PHP 7.2 is an outlier and I'm going to re-run the test suite
 to see if it's consistent.

 ||=PHP=||=Before=||=After=||=Change=||
 ||5.6  ||0.3158  ||2.8549 ||+2.5391 ||
 ||7.0  ||0.1396  ||1.0648 ||+0.9252 ||
 ||7.1  ||0.1789  ||0.3655 ||+0.1866 ||
 ||7.2  ||0.1460  ||1.2098 ||+1.0638 ||
 ||7.3  ||0.1547  ||0.4010 ||+0.2463 ||
 ||7.4  ||0.1146  ||0.7769 ||+0.6623 ||
 ||8.0  ||0.1091  ||0.2948 ||+0.1857 ||

 cc @cfinke

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50683#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform