[wp-trac] [WordPress Trac] #53891: GH Actions: enable running the tests on PHP 8.1

WordPress Trac noreply at wordpress.org
Sat Aug 7 14:12:41 UTC 2021


#53891: GH Actions: enable running the tests on PHP 8.1
-----------------------------------+-----------------------
 Reporter:  jrf                    |       Owner:  jrf
     Type:  task (blessed)         |      Status:  assigned
 Priority:  normal                 |   Milestone:  5.9
Component:  Build/Test Tools       |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch php81 early  |     Focuses:
-----------------------------------+-----------------------

Old description:

> PHP 8.1 is expected to be released end of November 2021.
> Enabling the tests to run in CI on PHP 8.1 will allow us to get WordPress
> ready in time.
>
> To allow for enabling the tests to run on PHP 8.1, quite some prep work
> needs/needed to be done ahead of the actual CI change.
>
> Preparation work already committed:
> * #47381 - removing of `composer.lock` file and switching to running the
> tests via Composer.
> * #46149 - making the test suite cross-version compatible with PHPUnit
> 5.x to 9.x
> * #53635 - [51517] patch `JsonSerializable_Object::jsonSerialize()` for
> compatibility with PHP 8.1
>
> Preparation work in progress:
> * #52825 - fix mysqli error handling for PHP 8.1.
> * #53858 - fix parse error in PHP 8.1 due to `readonly`
>
> Patches for these last two tickets need to be committed before PHP 8.1 in
> CI can be turned on as these are both causing fatal errors in the
> "Install WordPress" step before the actual test run.
>
> I'll be attaching a patch to this ticket for the CI change, but this
> patch can/should only be committed once the patches for the above two
> tickets are in.

New description:

 PHP 8.1 is expected to be released end of November 2021.
 Enabling the tests to run in CI on PHP 8.1 will allow us to get WordPress
 ready in time.

 To allow for enabling the tests to run on PHP 8.1, quite some prep work
 needs/needed to be done ahead of the actual CI change.

 Preparation work already committed:
 * #47381 - removing of `composer.lock` file and switching to running the
 tests via Composer.
 * #46149 - making the test suite cross-version compatible with PHPUnit 5.x
 to 9.x
 * #53635 - [51517] patch `JsonSerializable_Object::jsonSerialize()` for
 compatibility with PHP 8.1

 Preparation work in progress:
 * #52825 - fix mysqli error handling for PHP 8.1.
 * #53858 - fix parse error in PHP 8.1 due to `readonly`

 Patches for these last two tickets need to be committed before PHP 8.1 in
 CI can be turned on as these are both causing fatal errors in the "Install
 WordPress" step before the actual test run.

 I'll be attaching a patch to this ticket for the CI change, but this patch
 can/should only be committed once the patches for the above two tickets
 are in.

 Once the tests are running, the application of fixes for PHP 8.1 will be
 handled in #53635 and related tickets.

--

Comment (by jrf):

 I've opened [https://github.com/WordPress/wordpress-develop/pull/1553 PR
 1553] with the patch as uploaded and (partial) patches from the two
 tickets which still need to be committed to demonstrate/verify the CI on
 PHP 8.1 will work with those two changes.

 The fact that the tests fail is only to be expected for now.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53891#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list