[wp-trac] [WordPress Trac] #46149: PHPUnit 8.x support

[WordPress Trac]

#46149: PHPUnit 8.x support
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  netweb
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  high                                 |   Milestone:  5.9
Component:  Build/Test Tools                     |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests early php8  |     Focuses:
  needs-dev-note                                 |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 In [changeset:"51569" 51569]:
 {{{
 #!CommitTicketReference repository="" revision="51569"
 Tests: Remove use of `assertArraySubset()` in
 `Test_WP_Widget_Media::test_constructor()`.

 The `assertArraySubset()` method has been deprecated in PHPUnit 8 and
 removed in PHPUnit 9.

 This replaces the assertions with looping through the array and testing
 both the key and the value individually.

 References:
 *
 https://github.com/sebastianbergmann/phpunit/blob/8.0.6/ChangeLog-8.0.md#800
 ---2019-02-01
 * https://github.com/sebastianbergmann/phpunit/issues/3494

 Note: There is a polyfill package available for the removed assertion:
 `dms/phpunit-arraysubset-asserts`, but as the assertion was only used in
 this one test method, adding this seems redundant.

 Follow-up to [51559-51568].

 Props jrf.
 See #46149.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46149#comment:85>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform