[wp-trac] [WordPress Trac] #47381: Remove the Composer lock file from version control
WordPress Trac
noreply at wordpress.org
Wed Aug 4 18:55:55 UTC 2021
#47381: Remove the Composer lock file from version control
---------------------------------------------+-----------------------------
Reporter: johnbillion | Owner: hellofromTonya
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests commit | Focuses: coding-
| standards
---------------------------------------------+-----------------------------
Comment (by SergeyBiryukov):
In [changeset:"51543" 51543]:
{{{
#!CommitTicketReference repository="" revision="51543"
Build/Test Tools: Remove the Composer lock file from version control.
This makes it easier to run unit tests against multiple different PHP
versions.
There is currently no reason to have a `composer.lock` file as:
* External runtime dependencies are not managed via Composer.
* Managed updates of the non-runtime dependencies can be done by locking
the version used in the `composer.json` file to a precise version instead
of using a `composer.lock` file.
* Having the `composer.lock` file in place makes it a lot more difficult
to run the tests against all supported PHP versions.
With these considerations in mind, the lock file is now removed from
version control and added to `.gitignore` and `svn:ignore`.
Version constraints for the current dev dependencies are adjusted
accordingly:
* PHPUnit now explicitly declares in its version constraints that PHPUnit
5.x, 6.x, and 7.x are supported. The minimum supported version for PHPUnit
5.x has been raised from 5.4 to 5.7, which in practice was already the
version used for running the tests on PHP 5.6.
* PHPCompatibilityWP is effectively updated to version 2.1.2 with the
positive impact that a few new constants polyfilled in WP 5.8 are now
accounted for (excluded from being flagged).
* PHP_CodeSniffer is declared as an explicit dependency to ensure that
updates to it will always be explicitly managed instead of inherited.
* The DealerDirect Composer plugin is effectively updated to version 0.7.1
without impact.
Follow-up to [42960], [46290], [47881], [48957].
Props jrf, johnbillion, desrosj, ayeshrajans, aristath, hellofromTonya,
SergeyBiryukov.
See #47381.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47381#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list