[wp-trac] [WordPress Trac] #53626: Change Media upload failures string to not include "Security" messaging for each failure

[WordPress Trac]

#53626: Change Media upload failures string to not include "Security" messaging for
each failure
--------------------------------------+---------------------
 Reporter:  antpb                     |       Owner:  (none)
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  5.8.1
Component:  Media                     |     Version:  5.7
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+---------------------

Comment (by peterwilsoncc):

 The "not permitted for security reasons"
 [https://github.com/WordPress/gutenberg/blob/a7e2895829c16ecd77a5ba22d84f1dee1cfb0977/packages
 /media-utils/src/utils/upload-media.js#L131 version of the string also
 appears in Gutenberg], so an upstream PR to change that would be good.

 "Sorry, this file type is not supported here." looks to be about someone
 trying to upload an incompatible file to a block (eg an image to the audio
 block).

 For file types the user is prevented from uploading, I'm wondering if a
 more direct "Sorry, you are not allowed to upload this file type." is
 better. No security FUD if it's prevented because the site owner simply
 doesn't want to use a particular mime type on their site.

 Additionally...

 Is there a compelling reason this can't be held off to 5.9? Typically
 string changes are avoided as much as possible in minor releases to avoid
 the additional translation load on the polyglots.

 If it is a must have, then I suggest going with [attachment:"53626.diff"]
 in the 5.8 branch and creating a follow up ticket if you wish to go with a
 new string for 5.9.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53626#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform