[wp-trac] [WordPress Trac] #53830: Default filters try to create nonce during installation before options table exists

[WordPress Trac]

#53830: Default filters try to create nonce during installation before options
table exists
-------------------------------------------------+-------------------------
 Reporter:  schlessera                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.8.1
Component:  Upgrade/Install                      |     Version:  5.7
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-testing-info      |     Focuses:
  has-patch commit                               |
-------------------------------------------------+-------------------------
Changes (by hellofromTonya):

 * keywords:  needs-patch good-first-bug has-testing-info => good-first-bug
     has-testing-info has-patch commit


Comment:

 @SergeyBiryukov thanks for the testing instructions!

 @sanketchodavadiya thanks for the patch!

 [attachment:"53830.patch"] resolves the issue (see [#comment:5 testing
 report]) ✅

 Code review:
 - The patch implemented the suggested strategy ✅
 - The strategy is consistent with the other instances ✅
 - PHPCS/WPCS passes ✅
 {{{
 composer lint ./src/wp-admin/install.php
 > @php ./vendor/squizlabs/php_codesniffer/bin/phpcs
 --report=summary,source './src/wp-admin/install.php'
 . 1 / 1 (100%)
 }}}
 - Tests pass ✅
 {{{
 npm run test:php -- --stop-on-failure

 Tests: 12462, Assertions: 57798, Skipped: 21.
 }}}

 Marking for `commit`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53830#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform