[wp-trac] [WordPress Trac] #53858: PHP 8.1: syntax error due to new 'readonly' property

WordPress Trac noreply at wordpress.org
Mon Aug 2 14:44:25 UTC 2021


#53858: PHP 8.1: syntax error due to new 'readonly' property
--------------------------------------------+---------------------
 Reporter:  haosun                          |       Owner:  (none)
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  5.9
Component:  General                         |     Version:  4.9
 Severity:  normal                          |  Resolution:
 Keywords:  php81 needs-dev-note has-patch  |     Focuses:
--------------------------------------------+---------------------

Comment (by haosun):

 >
 > @haosun Could you perhaps test this on your setup to see if it works?
 >
 >

 @swissspidy  Yes. The syntax error is gone if function `readonly` is
 renamed or we use the code you provided.

 >
 > ------
 >
 > > Do you have any hints for this performance regression? Thanks.
 >
 > I don't think it's related. You would need to run these tests multiple
 times anyway to get a more meaningful result.

 I'm afraid the performance regression is still there. I did run the test
 for multiple times and get the performance data by computing the average
 value.

 As pointed by @jrf, there might exist the use sites of `readonly`. However
 we didn't use the new `wp_readonly` at these use sites. Do you think this
 might be the root cause of performance regression? Thanks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53858#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list