[wp-trac] [WordPress Trac] #53845: Add some more MySQL information to the Debug section in Site Health

[WordPress Trac]

#53845: Add some more MySQL information to the Debug section in Site Health
-------------------------+---------------------
 Reporter:  zodiac1978   |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  5.9
Component:  Site Health  |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+---------------------
Changes (by SergeyBiryukov):

 * keywords:  dev-feedback has-patch => has-patch


Comment:

 Thanks for the PR! It looks good to me.

 Some minor tweaks in [attachment:"53845.diff"]:

 * I think we should not use `size_format()` here. As previously noted in
 comment:1:ticket:52471, the purpose of the Site Health Info screen is to
 provide raw data as reported by PHP or MySQL for debugging purposes, so
 we'd want to avoid any modifications of the displayed data. This can be
 reconsidered later in #52471 if necessary.
 * Pretty much like database server version or client version, I don't
 think these new values should be marked as "private". That would prevent
 them from being copied when the "Copy site info to clipboard" button is
 clicked.
 * The labels should use sentence case rather than title case, for
 consistency with other labels.
 * The `::get_mysql_var()` method `@return` value should mention the
 expected result first.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53845#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform