[wp-trac] [WordPress Trac] #35725: Add WebP support.
WordPress Trac
noreply at wordpress.org
Fri Apr 30 01:52:58 UTC 2021
#35725: Add WebP support.
-------------------------------------------------+-------------------------
Reporter: markoheijnen | Owner:
| adamsilverstein
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.8
Component: Media | Version: 3.5
Severity: normal | Resolution:
Keywords: has-patch needs-testing has-unit- | Focuses:
tests needs-dev-note dev-feedback |
-------------------------------------------------+-------------------------
Comment (by adamsilverstein):
> I don't know if WebP handles this in a different fashion that might
make it easier.
@mikeschroder looks like the handling would have to be similar for WebP,
ie splitting into frames, going thru each frame, resizing, then combining
and output. Leaving that off for now since it is complicated and not part
of the original scope.
I had one other question for you: the patch adds quite a bit of image
handling code that only kicks in when the image object passed in not an
instance of `WP_Image_Editor`. Do you know if this is all legacy code, or
are their situations/user flows where these code paths would still be
used?
ie. this check in stream_image: https://github.com/WordPress/wordpress-
develop/blob/2b7cd8d4f3ae296b24089fbd53d360a4dbe30cee/src/wp-
admin/includes/image-edit.php#L267
and this one in save_image: https://github.com/WordPress/wordpress-
develop/blob/2b7cd8d4f3ae296b24089fbd53d360a4dbe30cee/src/wp-
admin/includes/image-edit.php#L333
--
Ticket URL: <https://core.trac.wordpress.org/ticket/35725#comment:171>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list