[wp-trac] [WordPress Trac] #52909: git repo README.md should include instructions to install svn

[WordPress Trac]

#52909: git repo README.md should include instructions to install svn
------------------------------+------------------------------
 Reporter:  czapla            |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:  docs
------------------------------+------------------------------
Changes (by jnylen0):

 * keywords:  reporter-feedback =>


Comment:

 Replying to [comment:2 czapla]:
 > > This command should be instructing Docker to execute the command
 within the local Docker development environment, which does have SVN
 installed.
 >
 > Oh, in that case, I believe that the whole command should be passed to
 the shell with `sh -c` or the second command should be prefaced with
 `docker-compose exec -T <container>` like:

 This is correct. `execSync( 'docker-compose exec -T commandA && commandB'
 )` will effectively run two commands, `docker-compose exec -T commandA`
 and `commandB`, because the `&&` is interpreted as a command separator by
 the underlying shell, and never gets passed to `docker-compose`.

 Also it seems like this may not work in Windows if it is supposed to (`&&`
 is a Linux-ism). A good way to restructure this could be as follows (needs
 testing):

 {{{#!javascript
 execSync( `docker-compose exec -T php rm -rf ${test_plugin_directory}`, {
 stdio: 'inherit' } );
 execSync( `docker-compose exec -T php svn checkout -r
 ${process.env.WP_IMPORTER_REVISION} https://plugins.svn.wordpress.org
 /wordpress-importer/trunk/ ${test_plugin_directory}`, { stdio: 'inherit' }
 );
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52909#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform