[wp-trac] [WordPress Trac] #52938: Twenty Twenty-One: H1 is misplaced for a page set as blogpost container

[WordPress Trac]

#52938: Twenty Twenty-One: H1 is misplaced for a page set as blogpost container
-------------------------------------+--------------------------------
 Reporter:  rianrietveld             |       Owner:  sabernhardt
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.8
Component:  Bundled Theme            |     Version:  5.6
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, accessibility
-------------------------------------+--------------------------------
Changes (by sabernhardt):

 * keywords:   => has-patch needs-testing
 * owner:  (none) => sabernhardt
 * status:  new => accepted


Comment:

 Thanks for the patches!

 The site-branding template needed editing, too, so it would not have two
 H1 headings.

 For edge cases, [attachment:"52938.2.diff"] simply does not output the
 header and H1 tags if there is no title (without the prefix). This could
 result in no H1 for the page, but I think that's better than outputting an
 empty tag.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52938#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform