[wp-trac] [WordPress Trac] #51423: Fix function argument type issues reported by PHPStan

WordPress Trac noreply at wordpress.org
Wed Apr 21 01:31:59 UTC 2021


#51423: Fix function argument type issues reported by PHPStan
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.8
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php8 has-patch has-unit-tests        |     Focuses:  coding-
  commit                                         |  standards
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 In [changeset:"50775" 50775]:
 {{{
 #!CommitTicketReference repository="" revision="50775"
 Upgrade/Install: Prevent possible type errors during installation.

 Prevent a `TypeError` from occurring during installation if `wp-
 config.php` is not writable. In PHP 8.0 this can cause a fatal error, in
 earlier versions of PHP a warning would be thrown.

 Account for a change in type returned by `fopen()` coming in a future
 version of PHP. Minor coding standards fixes in the `/wp-admin/setup-
 config.php` file.

 Props xknown, hellofromTonya, jrf, peterwilsoncc.
 See #51423.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51423#comment:100>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list