[wp-trac] [WordPress Trac] #52939: Frontend toolbar CSS conflict with some themes

[WordPress Trac]

#52939: Frontend toolbar CSS conflict with some themes
---------------------------------------+------------------------------
 Reporter:  keraweb                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Toolbar                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, css
---------------------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:   => has-patch has-screenshots
 * focuses:  ui => ui, css
 * version:  trunk =>


Comment:

 @keraweb Thanks for the report!

 I think adding a default text color could help with other plugins' toolbar
 information, too, and `inherit` seems to work better than setting a
 specific color. You still would need to adjust your plugin's styles a
 little (for text on buttons and against white).

 However, I would rather avoid adjusting core styles to correct a theme
 problem. [https://css-tricks.com/clearfix-a-lesson-in-web-development-
 evolution/ The clearfix hack] does not belong on elements without
 specifying a class, especially `div` or `ul`. So a few themes break more
 than the toolbar with that. The clearfix splits up the Yoast notification
 bubble and pushes the search input down, and it also means that the
 `alignleft` and `alignright` classes for floating media elements (in the
 content) are cleared every time.

 [[Image(https://live.staticflickr.com/65535/51017674755_11002a5cf0_n.jpg)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/52939#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform