[wp-trac] [WordPress Trac] #51315: Update mediaelement.js

[WordPress Trac]

#51315: Update mediaelement.js
--------------------------------------------+-----------------------
 Reporter:  desrosj                         |       Owner:  desrosj
     Type:  task (blessed)                  |      Status:  assigned
 Priority:  normal                          |   Milestone:  5.6
Component:  External Libraries              |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch needs-testing commit  |     Focuses:
--------------------------------------------+-----------------------

Comment (by desrosj):

 I wanted to document the weirdness that I just noticed in case anyone
 stumbles upon the same thing in the future.

 In [46436], MediaElementJS was updated to 4.2.13. However, `mejs.version`
 was
 [https://github.com/mediaelement/mediaelement/compare/4.2.12...4.2.13#commitcomment-35254787
 not bumped prior to tagging the 4.2.13 release], so it's value remained at
 `4.2.12`. When I linked to the comparison between versions above in
 comment:3, I examined `mejs.version` when choosing the version to compare
 4.2.16 with.

 This caused some inconsistencies in the diff comparisons and it took me a
 while to figure out where those inconsistencies were coming from.

 A [https://github.com/mediaelement/mediaelement/pull/2697/files#diff-
 57c401f024caa0f041ff8130e6f71255R52 temporary shim was added in 4.2.13]
 along with a few other changes to fix some breaking bugs. These temporary
 fixes were then removed in 4.2.15. Because the shim was not present in
 4.2.12 and Core was actually at 4.2.13, the original comparison posted
 above was missing the these deletions, but comparing `trunk` after
 updating to 4.2.16 was showing them.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51315#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform