[wp-trac] [WordPress Trac] #51399: Update sodium_compat to v1.13.x
WordPress Trac
noreply at wordpress.org
Sat Sep 26 20:50:40 UTC 2020
#51399: Update sodium_compat to v1.13.x
--------------------------------+--------------------
Reporter: SergeyBiryukov | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.6
Component: External Libraries | Version:
Severity: normal | Keywords: php8
Focuses: |
--------------------------------+--------------------
Previously: #48371
sodium_compat was updated to v1.12.1 in [46858] for WordPress 5.3.1.
Two new releases have been made since then:
https://github.com/paragonie/sodium_compat/releases/tag/v1.12.2
https://github.com/paragonie/sodium_compat/releases/tag/v1.13.0
List of changes from v1.12.1 to v1.13.0:
https://github.com/paragonie/sodium_compat/compare/v1.12.1...v1.13.0
For WordPress 5.6, one more particular fix is relevant for PHP 8
compatibility:
https://github.com/paragonie/sodium_compat/pull/119
In PHP 8, the `MB_OVERLOAD_STRING` constant has been removed along with
the `mbstring` function overload feature. This is now causing a test
failure:
{{{
1) Tests_File::test_file_signature_functions_as_expected
Error: Undefined constant "MB_OVERLOAD_STRING"
/var/www/build/wp-includes/sodium_compat/src/Core/Util.php:915
/var/www/build/wp-includes/sodium_compat/src/Core/Util.php:757
/var/www/build/wp-includes/sodium_compat/src/Compat.php:2858
/var/www/build/wp-includes/sodium_compat/lib/php72compat.php:1137
/var/www/build/wp-admin/includes/file.php:1348
/var/www/tests/phpunit/tests/file.php:198
}}}
The PR above is merged and fixes the issue. However, a new release is not
tagged yet, so we'll have to backport that commit separately for now, and
keep an eye on the next release.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/51399>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list