[wp-trac] [WordPress Trac] #50681: default-filters.php contains non-tweakable parameters

WordPress Trac noreply at wordpress.org
Fri Sep 25 21:29:27 UTC 2020

#50681: default-filters.php contains non-tweakable parameters
 Reporter:  rsepierre     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  5.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  coding-standards

Comment (by rsepierre):


 Please consider changing severity from "normal" to "blocker" again as it
 is PREVENTINT EVERY theme from handling the two arbitrary images sizes
 wordpress decided to add, and thus can add unfitted / unedittable behavior
 with the media library from wordpress core.

 I personally CAN NOT recommend any of my customers to update their
 wordpress CORE as it is not compatible with the theme and CAN NOT BE MADE
 As themes has to do with "appearance", mine including php and js scripts
 to handle dynamic image sizes generation, srcset, and lazy loading images
 for better loading time, quality and responsiveness.
 Every customer updating core will have polluting image sizes not fitted to
 work with the script and IMPOSSIBLE to customize (I would have to create a
 separate plugin just for this one parameter alone).

 I can assure you that many theme handle image sizes on their own (because
 native ones are quite messy) and I can provide links to examples (other
 than my own) if necessary.

 changing the hook from "plugins_loaded" to "init" is not only the
 **recommended wordpress standard** written in the documentation. It is
 also NOT BLOCKING every theme developer from interacting with the action.

 add_action( 'init', '_wp_add_additional_image_sizes', 0 );

 Severity should be BLOCKING because it is currently BLOCKING theme
 developers with arbitrary uneditable and, for some, unsuitable media
 library behavior.

Ticket URL: <https://core.trac.wordpress.org/ticket/50681#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list