[wp-trac] [WordPress Trac] #50686: UI issue on nav-menus.php

WordPress Trac noreply at wordpress.org
Thu Sep 24 23:58:01 UTC 2020

#50686: UI issue on nav-menus.php
 Reporter:  dilipbheda               |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.6
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch early                        |  css, administration
Changes (by helen):

 * keywords:  has-screenshots has-patch commit early => has-screenshots has-
     patch early


 I am famous for doing this but I am also very sorry in advance for it :) I
 think unfortunately in this case we do need to go at least a little bit
 wider for a fix that doesn't put us into a difficult place later. I don't
 think we need to go all the way into fixing `validateForm` from an
 accessibility point of view for the purposes of fixing this bug, but I
 think the correct approach here would not to be add a bunch of specific
 `:not` selectors to the CSS, but rather to add `.form-required` to the
 appropriate form inputs and use that existing naming.

 That said, because it's existing naming and affects both CSS and JS, going
 that route will need a lot of testing. I think the initial approach for
 the menus screen would be to add `.form-required` to the specific inputs
 that should be highlighted (not on a parent element) and add `.form-
 invalid .form-required { border }` to `forms.css`. From there, you would
 need to test that `validateForm` doesn't interfere with menus because of
 the way it works, and that the new CSS doesn't adversely affect other
 elements that already use `.form-required`.

 Does that make sense? I want to be clear that the patch isn't *bad*, it's
 just that I see this style of change as a bit of a red flag especially
 when it comes to trying to understand why it's this way in the future.

Ticket URL: <https://core.trac.wordpress.org/ticket/50686#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list