[wp-trac] [WordPress Trac] #51299: Remove the title attribute from Walker_Nav_Menu

WordPress Trac noreply at wordpress.org
Thu Sep 24 00:47:15 UTC 2020


#51299: Remove the title attribute from Walker_Nav_Menu
---------------------------------------+-----------------------------
 Reporter:  Hareesh Pillai             |       Owner:  Hareesh Pillai
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.6
Component:  Menus                      |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  title-attribute has-patch  |     Focuses:  accessibility
---------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Related: #24766, #32218.

 Thanks for the patch! Some thoughts:

 * From a technical point of view, if the `$title` variable is not used
 anywhere else in the class and is not passed to any filters, I don't think
 it makes sense to keep it. I see it being passed to the
 `nav_menu_item_title` filter, but the result is no longer used anywhere
 after this patch.
 * I think this will have big front-end implications for a lot of websites.
 For example, https://wordpress.org/ has these title attributes on some
 menu items. With this change, would they be gone?
  * Documentation: "Documentation, tutorials, best practices."
  * Forums: "Support and discussion forums."
  * Five for the Future: "How five percent is powering the next generation
 of the web"[[BR]]
 * Would this make the "Title Attribute" input on the Menus screen
 completely unused?
 * How would developers be able to restore previous behavior?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51299#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list