[wp-trac] [WordPress Trac] #51311: Update PHPMailer library

[WordPress Trac]

#51311: Update PHPMailer library
--------------------------------+---------------------
 Reporter:  desrosj             |       Owner:  (none)
     Type:  task (blessed)      |      Status:  new
 Priority:  normal              |   Milestone:  5.6
Component:  External Libraries  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:
--------------------------------+---------------------

Comment (by jrf):

 My two pennies:

 The PHPCompatibility check is something different than the CS checks for
 which external packages do not have to comply with WP code style
 requirement.

 All code shipped with WP should be compatible with the PHP versions
 supported by WP, including external packages.

 If we'd exclude those packages via the XML ruleset, it would defeat the
 purpose, as when a new version of PHPCompatibility comes out which
 includes new checks for, for instance, PHP 8.0, you wouldn't be notified
 about incompatibilities in the external packages, so you wouldn't know
 that:
 1. patches would need to be submitted to the external package(s)
 2. the next version of WP would need to include a newer version of the
 external package.

 So, with that in mind, I'd advocate using the inline annotations instead
 of the ruleset excludes.

 Copying over/rechecking the inline annotations on an update of an external
 package is a small price to pay to ensure that the code of those packages
 are still compatible with the WP supported PHP versions.

 If that is too much, I'd suggest trying to convince the authors of the
 external packages to use PHPCompatibility themselves, would still be
 better than doing a ruleset exclude. If the external packages would use
 PHPCompatibility, their package would already include the inline
 annotations, so when updating the package, we could then just copy & paste
 the files - including the annotations -.


 Does that make sense ?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51311#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform