[wp-trac] [WordPress Trac] #51311: Update PHPMailer library

[WordPress Trac]

#51311: Update PHPMailer library
--------------------------------+---------------------
 Reporter:  desrosj             |       Owner:  (none)
     Type:  task (blessed)      |      Status:  new
 Priority:  normal              |   Milestone:  5.6
Component:  External Libraries  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:
--------------------------------+---------------------

Comment (by desrosj):

 Thanks for [attachment:"51311.patch"] @ayeshrajans!

 I went back to see if I could find a reason for having the inline
 `phpcs:ignore` statements in PHPMailer instead of excluding the directory
 in the PHPCS ruleset. I couldn't find anything specific, but I think that
 the inline statements were used because of the work done towards achieving
 a passing compatibility job in [47902], which came before the library was
 actually updated in [48033] (so the inline statements were copied over).

 The only other argument I can think of for using inline statements vs.
 excluding the directory entirely in the ruleset is that the former would
 allow WordPress to more easily spot, report, and fix potential
 compatibility issues in PHPMailer as WordPress' supported versions of PHP
 are changed.

 I don't feel strongly either way, though I lean towards continuing to use
 the inline statements for the reason above. There are only 3-4 of them, so
 copying them over is not too time consuming. I'll hold off committing for
 a bit to allow others to weigh in if they have a preference. @jrf should
 be able to provide a recommendation here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51311#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform