[wp-trac] [WordPress Trac] #44354: Improve `WP_Privacy_Requests_Table` to manage columns

[WordPress Trac]

#44354: Improve `WP_Privacy_Requests_Table` to manage columns
-------------------------------------------------+-------------------------
 Reporter:  7studio                              |       Owner:  garrett-
                                                 |  eclipse
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.6
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  screenshots                                    |  administration
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch needs-testing => has-patch needs-testing has-
     screenshots
 * status:  assigned => accepted
 * milestone:  Future Release => 5.6


Comment:

 Thanks for ticket @7studio and the patches @birgire @pbiron they're
 looking great, I'm not seeing the errors I had before so probably was my
 own issue in the filter test code I was using.

 I've refreshed the patch in
 [https://core.trac.wordpress.org/attachment/ticket/44354/44354.3.diff
 44354.3.diff] to do minor updates to the phpdocs, but also added a
 `return;` to the end of `column_default()` as the list tables do expect a
 return value as it's output in the default list table class here;
 https://core.trac.wordpress.org/browser/tags/5.5.1/src/wp-admin/includes
 /class-wp-list-table.php#L1410

 I also reordered the column_ functions to have column_default first
 followed by the custom columns.

 Please review and retest and we can move this forward.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44354#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform