[wp-trac] [WordPress Trac] #50639: [PHP 8] Add @requires annotations for PHPUnit tests that assert engine-enforced constraints

WordPress Trac noreply at wordpress.org
Sun Sep 20 02:45:50 UTC 2020

#50639: [PHP 8] Add @requires annotations for PHPUnit tests that assert engine-
enforced constraints
 Reporter:  ayeshrajans                   |       Owner:  SergeyBiryukov
     Type:  defect (bug)                  |      Status:  reviewing
 Priority:  normal                        |   Milestone:  5.6
Component:  Build/Test Tools              |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  php8 has-patch needs-refresh  |     Focuses:

Comment (by SergeyBiryukov):

 In [changeset:"49009" 49009]:
 #!CommitTicketReference repository="" revision="49009"
 Tests: Skip some image tests if neither GD nor Imagick image editor
 engines are supported on the system.

 The explicit message brings some consistency with other image editor
 tests, specifically the ones using the `WP_Image_UnitTestCase` class.

 Previously, the tests were marked as "risky" in that scenario, due to
 performing no assertions.

 See #50639, #50640.

Ticket URL: <https://core.trac.wordpress.org/ticket/50639#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list