[wp-trac] [WordPress Trac] #51313: Incorrect regular expression in links_add_target function

WordPress Trac noreply at wordpress.org
Thu Sep 17 10:12:47 UTC 2020


#51313: Incorrect regular expression in links_add_target function
--------------------------------------+-----------------------------
 Reporter:  antonlukin                |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  5.6
Component:  Formatting                |     Version:  5.5.1
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"48983" 48983]:
 {{{
 #!CommitTicketReference repository="" revision="48983"
 Formatting: Make sure `links_add_target()` adds the `target` attribute to
 the correct tag.

 Previously, the attribute could unintentionally be added to a tag that
 starts with the same characters, e.g. `<aside>` instead of `<a>`.

 Props antonlukin.
 Fixes #51313.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51313#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list