[wp-trac] [WordPress Trac] #50639: [PHP 8] Add @requires annotations for PHPUnit tests that assert engine-enforced constraints
WordPress Trac
noreply at wordpress.org
Wed Sep 16 02:37:41 UTC 2020
#50639: [PHP 8] Add @requires annotations for PHPUnit tests that assert engine-
enforced constraints
------------------------------------------+-----------------------------
Reporter: ayeshrajans | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.6
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: php8 has-patch needs-refresh | Focuses:
------------------------------------------+-----------------------------
Comment (by SergeyBiryukov):
Looking at the media test failures, they appear to be caused by
[https://github.com/WordPress/wpdev-docker-
images/blob/84a4acfc15fd0bff04e3342e5c24a2c0ce5211cf/update.php#L181
missing 'gd' extension] in the [https://github.com/WordPress/wpdev-docker-
images WP Docker image].
The Docker image should probably be updated to provide the same list of
extensions for PHP 8 that we currently have for PHP 7.4 and older: `gd`,
`opcache`, `mysqli`, `zip`, `exif`, `intl`, `mbstring`, `xml`, `xsl`. If
anyone is able to help with that and open a PR, please do :)
Still, explicitly requiring `imagejpeg()` and related functions as
outlined in comment:3 would be better than the current obscure failures.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50639#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list