[wp-trac] [WordPress Trac] #38266: Tests: Use assertSame() when the type of the value in the assertion is important
WordPress Trac
noreply at wordpress.org
Sun Sep 13 15:19:54 UTC 2020
#38266: Tests: Use assertSame() when the type of the value in the assertion is
important
-----------------------------------+-----------------------------
Reporter: johnbillion | Owner: SergeyBiryukov
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 5.6
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: needs-unit-tests php8 | Focuses:
-----------------------------------+-----------------------------
Comment (by SergeyBiryukov):
In [changeset:"48974" 48974]:
{{{
#!CommitTicketReference repository="" revision="48974"
Tests: Correct assertion in
`Tests_DB::test_prepare_incorrect_arg_count()`.
On failure, `wpdb::prepare()` returns either an empty string or `null`,
not `false`.
The test only passed accidentally due to `assertEquals()` not performing a
strict type check.
Follow-up to [41662].
See #38266.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38266#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list