[wp-trac] [WordPress Trac] #50913: PHP 8.0: various compatibility fixes

WordPress Trac noreply at wordpress.org
Fri Sep 11 11:39:13 UTC 2020


#50913: PHP 8.0: various compatibility fixes
-------------------------------------------+-------------------------------
 Reporter:  jrf                            |       Owner:  SergeyBiryukov
     Type:  task (blessed)                 |      Status:  reviewing
 Priority:  normal                         |   Milestone:  5.6
Component:  General                        |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  php8 has-patch needs-dev-note  |     Focuses:  coding-standards
-------------------------------------------+-------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:23 SergeyBiryukov]:
 > These all require a post ID to check, and will cause a PHP notice if the
 ID is not provided. Performing these checks without passing in a post ID
 (or a comment ID, in case of `edit_comment`) is a developer error, so I
 think the notice is legitimate, hiding it would only make debugging
 harder.

 Found an existing open ticket for this: #44591, let's add a
 `_doing_it_wrong()` notice there.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50913#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list