[wp-trac] [WordPress Trac] #42663: Imagick support for stream wrappers

[WordPress Trac]

#42663: Imagick support for stream wrappers
-------------------------------------------------+-------------------------
 Reporter:  calin                                |       Owner:
                                                 |  mikeschroder
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.6
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion has-unit-      |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by p00ya):

 Open questions regarding my github PR:

 1. should I add support for very old versions of the imagick extension as
 @calin's patch did?  Pros: works with old PHP; Cons: adds some code bloat.
 2. should I try and call make_image from _save like @calin's patch did.
 Pros: ??; Cons: convoluted code.
 3. should I add a dummy stream wrapper for testing like @calin's patch did
 instead of testing with `file://` URLs?  Pros: more likely to pick up
 future bugs if the code relies on features like seekable streams; Cons:
 bunch of extra code in the tests for the fake stream.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42663#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform