[wp-trac] [WordPress Trac] #50774: include version updated FROM in plugin/theme auto-updates emails

WordPress Trac noreply at wordpress.org
Thu Sep 10 18:09:53 UTC 2020


#50774: include version updated FROM in plugin/theme auto-updates emails
-------------------------------------+-----------------------
 Reporter:  pbiron                   |       Owner:  audrasjb
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.6
Component:  Upgrade/Install          |     Version:  5.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------

Comment (by pbiron):

 I've done some initial testing of [attachment:"50774.1.diff"].  It seems
 to work as expected for plugins hosted in the .org repo.

 However, for externally hosted plugins, depending on how the update
 information is injected into the site transient, the current version may
 still not be available when the email notifications are sent.

 For example, if a plugin hooks into
 `pre_set_site_transient_update_plugins` or `site_transient_update_plugins`
 to inject their info into `$transient->response` then `current_version`
 will not be set.

 With that patch, the only way `current_version` will be set (to other than
 "N/A") is if one of the low-level Requests hooks (e.g., `http_response`)
 is used to inject the update info...and using those hooks to inject update
 info for externally hosted plugins is **very** uncommon in my experience.

 I've got a couple of different ideas of how to remedy this, will
 investigate and upload a revised patch when I've done that.

 p.s. all of the above applies to externally hosted themes as well.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50774#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list