[wp-trac] [WordPress Trac] #38266: Tests: Use assertSame() when the type of the value in the assertion is important

WordPress Trac noreply at wordpress.org
Mon Sep 7 03:26:47 UTC 2020


#38266: Tests: Use assertSame() when the type of the value in the assertion is
important
-----------------------------------+-----------------------------
 Reporter:  johnbillion            |       Owner:  SergeyBiryukov
     Type:  defect (bug)           |      Status:  accepted
 Priority:  normal                 |   Milestone:  5.6
Component:  Build/Test Tools       |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  needs-unit-tests php8  |     Focuses:
-----------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"48953" 48953]:
 {{{
 #!CommitTicketReference repository="" revision="48953"
 Tests: Remove the polyfill for `assertNotFalse()`.

 `assertNotFalse()` is available in PHPUnit since version 4.0.

 The polyfill was introduced back when WordPress still supported PHP 5.2
 and PHPUnit 3.6.x, and is now redundant.

 Follow-up to [39919], [45058], [47880].

 See #38266.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38266#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list