[wp-trac] [WordPress Trac] #51248: Rename WP_Comments_List_Table::comment_status_dropdown() to ::comment_type_dropdown()

[WordPress Trac]

#51248: Rename WP_Comments_List_Table::comment_status_dropdown() to
::comment_type_dropdown()
----------------------------+-----------------------------
 Reporter:  SergeyBiryukov  |       Owner:  SergeyBiryukov
     Type:  defect (bug)    |      Status:  accepted
 Priority:  normal          |   Milestone:  5.6
Component:  Comments        |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  administration
----------------------------+-----------------------------
Description changed by SergeyBiryukov:

Old description:

> Background: #40188, #50815.
>
> [48521] introduced a method for displaying a comment type drop-down for
> filtering on the Comments list table.
>
> For some reason, the method is called `::comment_status_dropdown()`,
> despite not having to do anything with a comment status. This can be
> confusing now and problematic when working on tickets like #20977 in the
> future.
>
> I propose renaming the method to `::comment_type_dropdown()` for clarity.
> It's marked as protected, so there should not be any backward
> compatibility concerns.

New description:

 Background: #40188, #50815.

 [48521] introduced a method for displaying a comment type drop-down for
 filtering on the Comments list table.

 For some reason, the method is called `::comment_status_dropdown()`,
 despite not having anything to do with a comment status. This can be
 confusing now and problematic when working on tickets like #20977 in the
 future.

 I propose renaming the method to `::comment_type_dropdown()` for clarity.
 It's marked as protected, so there should not be any backward
 compatibility concerns.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51248#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform