[wp-trac] [WordPress Trac] #49274: Grunt copy:files should ignore node_modules

WordPress Trac noreply at wordpress.org
Fri Sep 4 19:59:47 UTC 2020


#49274: Grunt copy:files should ignore node_modules
------------------------------+------------------------------
 Reporter:  iandunn           |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+------------------------------

Comment (by iandunn):

 [attachment:"49274.2.diff"] adds additional ignore entries for `build` and
 `build-*` folders, which fixes the `max call stack` error with Gutenberg
 (comment:3). The `watch` task takes ~25 seconds to run, though, so it's
 still unusable.

 [attachment:"49274.3.diff"] takes a more radical approach, and ignores all
 of `wp-content`. This solves the speed issue, but has the (somewhat)
 unintended consequence of preventing `mu-plugins`, `plugins`, and `themes`
 from being copied from `src` to `build`.

 I often need to test plugins against trunk, especially Gutenberg, so that
 seems like a reasonable use case. People could create & build those things
 directly in WP's `build` folder, but it doesn't seem like `build` is
 really a safe location for anything that isn't in `src`. I often `rm -rf
 build` when troubleshooting.

 Does anyone have any thoughts?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49274#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list