[wp-trac] [WordPress Trac] #48325: Additional filter in media-template.php. Let developers to hide attachment page link.

WordPress Trac noreply at wordpress.org
Tue Sep 1 15:50:14 UTC 2020


#48325: Additional filter in media-template.php. Let developers to hide attachment
page link.
------------------------------------+-----------------------------
 Reporter:  limera1n                |       Owner:  (none)
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  Future Release
Component:  Media                   |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  ui
------------------------------------+-----------------------------

Comment (by garrett-eclipse):

 Thanks @Mista-Flo that's great, I think it's looking really well.

 Only issue I see now is with the separator functionality. Prior to our
 changes there was always a first item so all following conditional items
 could just place the separator first and it would always work nicely.

 Now if there's not a following item due to the conditionals we can end up
 with a orphaned separator on the end. There's two approaches (maybe more)
 not sure what's best; we could wrap conditionals around the separators to
 check there's going to be a following item, or we could drop them in the
 html and move to CSS to place as an after element only when `element +
 element` selector works. Or there might be css we can use to hide that
 orphaned separator.

 Thoughts?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48325#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list