[wp-trac] [WordPress Trac] #49412: Store filesize media metadata

WordPress Trac noreply at wordpress.org
Thu Oct 29 05:46:36 UTC 2020


#49412: Store filesize media metadata
--------------------------------------+-----------------------------
 Reporter:  Cybr                      |       Owner:  (none)
     Type:  feature request           |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  Media                     |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+-----------------------------

Comment (by johnwatkins0):

 @spacedmonkey @swissspidy I have updated via the PR linked above.
 Unexpectedly, I discovered that `filesize` was returning slightly
 different results in the different GHA test environments. I struggled with
 this a bit and ended up creating a test utility function to round file
 sizes in the tests to the nearest thousand bytes. I think this is okay in
 principle because we don't care about the exact sizes of the test files as
 long as the actual and expected results generally match, but I still
 wonder if there might be a simpler approach. LMK if you have any
 suggestions.

 There remain some test failures on my PR, but I see the same failures on
 the latest commit to `master`. I'll check back on this tomorrow.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49412#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list