[wp-trac] [WordPress Trac] #51661: Remove GLOB_BRACE from unittest functions.

WordPress Trac noreply at wordpress.org
Thu Oct 29 04:09:09 UTC 2020


#51661: Remove GLOB_BRACE from unittest functions.
--------------------------+-----------------------------
 Reporter:  amykamala     |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Media         |    Version:
 Severity:  normal        |   Keywords:  needs-patch
  Focuses:                |
--------------------------+-----------------------------
 [ from @sawanoboly https://github.com/WordPress/phpunit-test-
 runner/issues/128 ]

 "One of the unit tests uses the GLOB_BRACE option for glob.

 https://github.com/digitalcube/wordpress-
 develop/blob/master/tests/phpunit/tests/image/functions.php#L22-L27

 The GLOB_BRACE option is not supported by some libc-compatible
 implementations. Solaris is shown as an example in the documentation, but
 it cannot use this option on other implementations, such as alpine linux,
 which uses musl-libc.

 https://www.php.net/manual/en/function.glob.php

 I'd like to see them switch to an implementation that doesn't use
 GLOB_BRACE, as it seems to be just cleaning up the files, regardless of
 compatibility."

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51661>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list