[wp-trac] [WordPress Trac] #51445: [Multiple Bundled Themes] Add theme support for navigation-widgets

[WordPress Trac]

#51445: [Multiple Bundled Themes] Add theme support for navigation-widgets
----------------------------+----------------------------
 Reporter:  Hareesh Pillai  |       Owner:  williampatton
     Type:  task (blessed)  |      Status:  reopened
 Priority:  normal          |   Milestone:  5.6
Component:  Bundled Theme   |     Version:  5.5
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  accessibility
----------------------------+----------------------------
Changes (by sabernhardt):

 * keywords:  needs-testing =>


Comment:

 There are no visible differences in my tests with Firefox (Windows),
 trying LTR and RTL languages and two screen/browser widths.

 While Twenty Fifteen and Twenty Sixteen `ul` styles do have a bottom
 margin they didn't have before, the new margin does not increase the
 `.widget` container's greater bottom margin. If we want to remove this
 margin anyway, [attachment:"51445.2.diff"] can do that for these two
 themes. Otherwise, this ticket could be re-closed, as is.

 ==== Twenty Twenty

 There are three selectors involving the divs:
 `.widget-content > div > *:first-child`
 `.widget-content > div > *:last-child`
 `.widget_nav_menu .widget-content > div > ul`

 However, the widget's list styles have a margin of 0 (all directions) both
 before and after the change,
 [https://themes.trac.wordpress.org/browser/twentytwenty/1.5/style.css#L4169
 due to this]:

 {{{
 .widget_archive ul, .widget_categories ul, .widget_pages ul, .widget_meta
 ul, .widget_nav_menu ul, .widget_recent_comments ul,
 .widget_recent_entries ul, .widget_rss ul {
     list-style: none;
     margin: 0;
 }
 }}}

 Also the tag cloud doesn't use the list tags in Twenty Twenty, so no
 change is necessary for that either.

 ==== Twenty Sixteen

 The tag cloud list had a bottom margin and still does. The other widget
 lists now have a margin that the following used to override, though it's
 not noticeable.

 {{{
 .widget > :last-child {
     margin-bottom: 0;
 }
 }}}

 ==== Twenty Fifteen

 Similarly to Twenty Sixteen, the tag cloud and most other navigation
 widget `ul` lists have a margin with the new markup. The RSS widget,
 however, retains the zero-margin:

 {{{
 .widget_rss ul {
         list-style: none;
         margin: 0;
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51445#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform