[wp-trac] [WordPress Trac] #51592: Customizer: Create New Menu is Empty

[WordPress Trac]

#51592: Customizer: Create New Menu is Empty
------------------------------+---------------------
 Reporter:  boldgrid          |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  5.6
Component:  Customize         |     Version:  trunk
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+---------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch needs-testing => has-patch commit


Comment:

 Replying to [comment:17 westonruter]:
 > That being said, I don't recall why `control.renderContent()` was being
 made conditional upon `parentContainer` not being the
 `control.container.parent()`. Moving it outside of that conditional makes
 sense to me, and I'm not seeing any other regressions caused by doing so.

 It's worth noting that there is a
 [source:tags/5.5.1/src/js/_enqueues/wp/customize/controls.js?marks=2813#L2797
 similar fragment for panels] earlier in the file, where
 `panel.renderContent()` is called outside of the conditionals:
 {{{
 if ( ! panel.headContainer.parent().is( parentContainer ) ) {
         parentContainer.append( panel.headContainer );
 }
 if ( ! panel.contentContainer.parent().is( panel.headContainer ) ) {
         container.append( panel.contentContainer );
 }
 panel.renderContent();
 }}}

 So the patch brings some consistency and works as expected in my testing.
 Marking for commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51592#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform