[wp-trac] [WordPress Trac] #51389: REST API: WP_REST_Meta_Fields::default_additional_properties_to_false assumes that the schema has properties.

WordPress Trac noreply at wordpress.org
Sun Oct 25 16:44:48 UTC 2020


#51389: REST API: WP_REST_Meta_Fields::default_additional_properties_to_false
assumes that the schema has properties.
----------------------------------------+---------------------
 Reporter:  austin880625                |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  5.6
Component:  REST API                    |     Version:  4.9
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:
----------------------------------------+---------------------

Comment (by TimothyBlynJacobs):

 Thanks for the refreshed patch @austin880625! We still need to keep the
 method around since developers who are extending the class may be using
 the method. So instead of removing it, we should instead mark it as
 deprecated and use `_deprecated_function`.

 For example: https://github.com/WordPress/wordpress-
 develop/blob/9eed4bc352c944ce75c3ff1615bc63b7162af88b/src/wp-includes
 /rest-api/search/class-wp-rest-post-search-handler.php#L191

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51389#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list