[wp-trac] [WordPress Trac] #51592: Customizer: Create New Menu is Empty

WordPress Trac noreply at wordpress.org
Sat Oct 24 08:29:50 UTC 2020


#51592: Customizer: Create New Menu is Empty
--------------------------+---------------------
 Reporter:  boldgrid      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.6
Component:  Customize     |     Version:  trunk
 Severity:  blocker       |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+---------------------

Comment (by david.binda):

 > That shouldn't be caused by the 1.9 changes (since it works in
 1.12.4-wp).

 Right. I was too fast with my judgement there while looking for possible
 cause upstream. However, if my testing is correct, the code's behaviour
 changes in between jQuery 2.2.4 and 3.0.0 (as in the `.parent()` is not
 returning the parent for `control.container` ).

 The biggest part of the diff in between the 2.2.4 and 3.0.0 is the
 Deferred element you are mentioning.

 However, even in 2.2.4, the parentNode seems to be set (just `.parent()`
 is not returning it).

 I wonder, can't the `control.renderContent();` call be moved outside of
 the conditional leaving only the `.append` inside?

 In r41482 there seems to be a similar change, however a part of a bigger
 changeset, so I'm not really sure why it was needed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51592#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list