[wp-trac] [WordPress Trac] #50686: UI issue on nav-menus.php
WordPress Trac
noreply at wordpress.org
Fri Oct 23 15:03:52 UTC 2020
#50686: UI issue on nav-menus.php
-------------------------------------+-------------------------------------
Reporter: dilipbheda | Owner: audrasjb
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 5.6
Component: Menus | Version:
Severity: normal | Resolution: fixed
Keywords: has-screenshots has- | Focuses: ui, accessibility,
patch needs-testing | css, administration
-------------------------------------+-------------------------------------
Changes (by helen):
* status: accepted => closed
* resolution: => fixed
Comment:
In [changeset:"49283" 49283]:
{{{
#!CommitTicketReference repository="" revision="49283"
Administration: Better targeting for required form field highlighting.
Previously, any `input` or `select` inside of a `.form-invalid` wrapper
would get the red border highlighting, including submit buttons which was
not visually correct. This now only applies to form elements with a class
of `.form-required` inside of the `.form-invalid` wrapper. It also
continues to apply the border to elements with both classes (`.form-
invalid.form-required`) as that is how some of the admin markup is
structured.
Plugin authors may need to do the same sort of class application seen in
this commit, i.e. add `.form-required` to certain form elements.
Props sabernhardt, dilipbheda, helen.
Fixes #50686.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/50686#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list