[wp-trac] [WordPress Trac] #50849: Incorrect action passed to hooks when updating plugin/theme by uploading ZIP file

[WordPress Trac]

#50849: Incorrect action passed to hooks when updating plugin/theme by uploading
ZIP file
-------------------------------------+---------------------
 Reporter:  desrosj                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.5.2
Component:  Upgrade/Install          |     Version:  5.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------

Comment (by desrosj):

 Revisiting this, the hook should not be fired twice. Let's move to fire it
 only after the replacement is made and the update is complete.

 > The code can be abstracted to the base class as a protected method. Then
 it's available for both the theme and plugin classes to directly invoke
 that new method.

 This should be fine! But we'll just need to test all of the different
 scenarios carefully to confirm.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/50849#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform