[wp-trac] [WordPress Trac] #46363: Images in about.php should be served locally, not from s.w.org

[WordPress Trac]

#46363: Images in about.php should be served locally, not from s.w.org
-------------------------------------------------+-------------------------
 Reporter:  pputzer                              |       Owner:  garrett-
                                                 |  eclipse
     Type:  task (blessed)                       |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.6
Component:  Help/About                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:  css,
  testing dev-feedback                           |  privacy
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-screenshots => has-screenshots has-patch needs-testing
     dev-feedback
 * focuses:  privacy => css, privacy


Comment:

 I've uploaded an initial patch
 [https://core.trac.wordpress.org/attachment/ticket/46363/46363.2.diff
 46363.2.diff] to illustrate the concept I had on reducing the image size.

 In fact in the [https://core.trac.wordpress.org/raw-
 attachment/ticket/46363/freedoms.2.png freedoms.2.png] has cut that size
 into a quarter (~460kb down to now ~108kb) by reducing the max image width
 into half it's original.

 A few notes as this is only an initial patch and could be improved;
 1. I tweaked the existing `.has-4-columns` class to achieve this. I fear
 this is or will be used for another implementation where they wanted the
 original responsive behaviour. To resolve this we could maybe introduce a
 new `.has-2-mid-columns` class to apply our styles specifically.
 2. I changed the name from freedoms-2x.png to just freedoms.png in the
 patch, but the image I uploaded since there was another prior was renamed
 to freedoms.2.png so when downloading please rename.
 3. I introduced a new breakpoint at 420px after testing and found that
 kept the images when 2 column still looking nice and achieved the exact
 1/2 of our original size allowing me to just use the pre-existing 1x
 version of the freedoms image off the CDN. Note: I only found that
 coincidence after I'd found a breakpoint I was happy with sizing on.

 CC @SergeyBiryukov

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46363#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform